Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address part of #11: Fully embrace RFC 8949 encoding indicator syntax #15

Merged
merged 4 commits into from
Oct 9, 2023

Conversation

cabo
Copy link
Collaborator

@cabo cabo commented Oct 6, 2023

  • Remove spurious spaces in front of them
  • Allow them behind all strings and numbers
  • Allow then right after the tag number
  • Add embedded to the bstr choice (So now also allow them in streamstring)

Encoding Indicator within streamstring addressed in commit below.
With app-string in the picture, there no longer is a syntactic way to
check that the chunks of streamstrings are all text or all bytes.

* Remove spurious spaces in front of them
* Allow them behind all strings and numbers
* Allow then right after the tag number
* Add embedded to the bstr choice
  (So now also allow them in streamstring)

Still need to address ei within streamstring
@cabo cabo requested a review from chrysn October 6, 2023 08:26
@cabo cabo mentioned this pull request Oct 6, 2023
With app-string in the picture, there no longer is a syntactic way to
check that the chunks of streamstrings are all text or all bytes.
@cabo cabo changed the title Fully embrace RFC 8949 encoding indicator syntax Address part of #11: Fully embrace RFC 8949 encoding indicator syntax Oct 8, 2023
@cabo cabo merged commit 98ff224 into main Oct 9, 2023
2 checks passed
@cabo cabo deleted the encoding-indicators branch May 17, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants