-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feedback #1
base: feedback
Are you sure you want to change the base?
Feedback #1
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
backend changes for implement user dashboard
packages/backend/controllers/quiz.ts
Outdated
// } | ||
// ) | ||
|
||
router.post("/", authenticate, async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
packages/backend/controllers/user.ts
Outdated
|
||
router.get( | ||
"/", | ||
authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
disable sign in/sign up if already logged in
packages/backend/controllers/quiz.ts
Outdated
|
||
router.get( | ||
"/", | ||
authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
packages/backend/controllers/quiz.ts
Outdated
|
||
router.get( | ||
"/routine", | ||
authenticate, |
Check failure
Code scanning / CodeQL
Missing rate limiting High
authorization
add logout
styling changes
tweaks (styling, unused code, question format)
fix routine not showing
deployment ready code
fix procfile
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
main
since the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips:
main
since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue + (plus sign). To learn more about comments, read “Commenting on a pull request”.main
. Click a commit to see specific changes.For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @canams