Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instagram): voice clip #1591

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nuexq
Copy link

@nuexq nuexq commented Jan 24, 2025

🔧 What does this fix? 🔧

this fix Play, Pause and Timer background colors and closes #1590.

incoming voice clip:

  • Before:
    Image
  • After:
    image

outgoing voice clip:

  • Before:
    image
  • After:
    image

voice clip recording:

  • Before:
    image
  • After:
    image

🗒 Checklist 🗒

  • I have read and followed Catppuccin's contributing guidelines.
  • fixing sumthing wrong's popup box background color apply to voice clip
  • Play and Pause and Timer background color for better visibility
  • outgoing voice clip fix
  • voice clip recording fix

@nuexq nuexq requested a review from GenShibe as a code owner January 24, 2025 10:32
@github-actions github-actions bot added the instagram Instagram label Jan 24, 2025
@nuexq nuexq marked this pull request as draft January 24, 2025 11:47
@nuexq nuexq marked this pull request as ready for review January 24, 2025 12:24
@uncenter
Copy link
Member

Looks like the unplayed part of an incoming voice clip is still unthemed.

@nuexq
Copy link
Author

nuexq commented Jan 24, 2025

Looks like the unplayed part of an incoming voice clip is still unthemed.

no that's just because the audio length is small, instagram doesn't fill all the voice clip, this is how the unplayed part will be:
image

@uncenter
Copy link
Member

I was looking at this part:
image
The second have of the wavelength is not themed.

@nuexq
Copy link
Author

nuexq commented Jan 24, 2025

I was looking at this part: image The second have of the wavelength is not themed.

actually it is but it's hard to see, you can see that the color changed, but I'll try to make it more visible

@uncenter
Copy link
Member

It isn't themed, I can color pick the hex code as #b2b2b2 which seems far off from the palette.

@nuexq
Copy link
Author

nuexq commented Jan 24, 2025

Oh, I see, I misunderstood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instagram Instagram
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Instagram voice clip background color
2 participants