Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pinterest): misc #1581

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

fix(pinterest): misc #1581

wants to merge 41 commits into from

Conversation

nuexq
Copy link

@nuexq nuexq commented Jan 16, 2025

🔧 What does this fix? 🔧

add multiple messing variables like --color-background-box-info-weak, --color-background-tabs-base...

  • adding --color-background-box-info-weak variable
  • adding --color-text-formfield-default variable
  • adding --color-background-tabs-(base/hover) variables
  • edit --color-background-box-light to match bg color
  • remove the @text style for pin hover icons (doesn't match there bg)
  • change pin hover icons bg to match theme
  • adding switch background and borders variables
  • adding checkbox background and borders variables
  • adding --color-background-button-white-(default/hover) variables

🗒 Checklist 🗒

@github-actions github-actions bot added the pinterest Pinterest label Jan 16, 2025
@uncenter uncenter changed the title fix(Pinterest): adding multiple messing variables + fixing pin hover icon colors fix(pinterest): variables & pin hover icon Jan 16, 2025
@uncenter uncenter marked this pull request as draft January 17, 2025 17:48
@nuexq nuexq changed the title fix(pinterest): variables & pin hover icon fix(pinterest): multiple fixes Jan 18, 2025
@uncenter uncenter marked this pull request as ready for review January 18, 2025 21:07
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
styles/pinterest/catppuccin.user.less Outdated Show resolved Hide resolved
@uncenter
Copy link
Member

Not that it matters much, but since you used style(pinterest):...

style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)

The Conventional Commits standard references the Angular commit convention types, which says that style should be used for the above. style(pinterest): formfield primary color to base instead of faded su… would more accurately be fix(pinterest): ....

@uncenter uncenter changed the title fix(pinterest): multiple fixes fix(pinterest): misc Jan 21, 2025
@nuexq
Copy link
Author

nuexq commented Jan 23, 2025

I think this is good for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinterest Pinterest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants