-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(searxng): make links blue and visited links mauve #1450
base: main
Are you sure you want to change the base?
Conversation
The default accent is always the same across websites, we don't change it for specific userstyles. |
In that case it's probably best to hard-code links as blue Should visited links be hard-coded as mauve or be accented? |
Well, according to the style guide visited/followed links would be lavender I believe, not mauve. We haven't made a complete decision on accent links vs style guide links yet, it is likely up to the maintainer to decide which they think looks better for a specific userstyle. |
Lavender is not quite distinct enough from blue at a glance, so I think I'll still go with mauve like the Brave and DDG userstyles. |
Not sure where |
Just my two cents, I don't think we should accept a contribution that is against the style guide. We're not making a tradeoff to improve some other highlight in this case either.
In the future, we can probably look towards supporting this with official shades? Curious what @isabelroses and @uncenter think. |
Do the other browser userstyles have to have visited links be changed to lavender then?
Not quite clear on what this means, sorry |
I believe the style guide wasn't necessarily followed here since lavender itself is offered as an accent colour. I don't think it's feasible to update all the userstyles to that. We'll probably have to define official shades of colours as part of the style guide so that userstyles can standardise on the amount to lighten/darken the links for hover/visited.
Sorry ignore me there, what I said wasn't really relevant. |
This shouldn't be a problem since this PR would make links no longer accented; they'd just be blue and mauve (or blue and lavender, if we must adhere to the style guide) so there shouldn't be any clashing.
That would be ideal, but for now this is probably the best way to re-add this functionality of distinguishing visited links. |
🔧 What does this fix? 🔧
As the title says, distinguishes links from visited links by making them blue and mauve respectively instead of all being the accent colour.
🗒 Checklist 🗒
==UserStyle==
header of thecatppuccin.user.css
file.