forked from zendesk/ruby-kafka
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PT-5027] Add ruby 3.0 and 3.1 test matrix support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
pablomg92z
commented
Feb 17, 2023
muripic
approved these changes
Feb 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Please add in the description that we did not fix the errors and go for the change to the Confluent image in this PR because:
|
done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See https://catawiki.atlassian.net/browse/PT-5027.
This PR adds circleCI tests for ruby 2.7, 3.0 and 3.1, both unit tests and functional tests against a kafka docker image that has the same version as the one we use in production. However, the provider of the image is wurstmeister instead of confluent which is the one we use in production. The reasons for this are:
wurstmeister
image was the one already used with the library, so we didn't make any changes thereType of change
How has this been tested?
Checklist
Deployment notes
We need to generate a new gem release. The only code change is related to datadog, which we do not use, so there should be no functionality changes or issues upgrading to this version.