Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#174] Add error log check back in #202

Merged
merged 2 commits into from
Nov 14, 2024
Merged

[#174] Add error log check back in #202

merged 2 commits into from
Nov 14, 2024

Conversation

matthewhilton
Copy link
Contributor

@matthewhilton matthewhilton commented Nov 14, 2024 •
edited
Loading

Closes #174

Changes

  • Adds back in the error log pinging, which was removed during a cleanup.
  • Added just into the croncheck page instead of check api. If we had the ability to read back the error log to do a complete e2e test, it would be a check class, but since we cannot there's no point since the check can't actually check anything.

Testing

  • Covered by unit tests
  • Also tested manually

Pull request checks

  • I have checked the version numbers are correct as per the README

@brendanheywood brendanheywood enabled auto-merge (rebase) November 14, 2024 04:06
@brendanheywood brendanheywood merged commit 49f1266 into MOODLE_39_STABLE Nov 14, 2024
29 checks passed
@brendanheywood brendanheywood deleted the 174-error-log-check branch November 14, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendanheywood brendanheywood brendanheywood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a new error_log check
2 participants
@matthewhilton @brendanheywood