-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Proof-of-concept Implementation for new save format (#5771) #5772
base: main
Are you sure you want to change the base?
Conversation
…nteam#5771) Signed-off-by: David Li <[email protected]>
Autofix has formatted code style violation in this PR. I edit commits locally (e.g: git, github desktop) and want to keep autofix
I do not want the automated commit
If you don't do this, your following commits will be based on the old commit, and cause MERGE CONFLICT. |
This iteration does not implement compression, only consolidates the |
|
||
#include <functional> | ||
#include <string> | ||
#include <sqlite3.h> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Avoid pulling in sqlite3 header into game.h
std::cerr << "SQL Write: " << path << " ..." << parent << " ..."; | ||
|
||
// sqlite3_exec( db, "BEGIN TRANSACTION", 0, 0, 0 ); | ||
const char *sql = "INSERT INTO files(path, parent, data) VALUES (:path, :parent, :data)"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Derp - forgot the upsert clauses. Will be fixed in the next iteration.
This is an early proof-of-concept for #5771 and is not intended to be merged.
Checklist
Required
main
so it won't cause conflict when updatingmain
branch later.Optional
Purpose of change
Describe the solution
Describe alternatives you've considered
Testing
Additional context