Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Rspec convention in favour of solargraph-rspec plugin #716

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

lekemula
Copy link
Contributor

@lekemula lekemula commented May 26, 2024

Hi,

ICYMI: #683 (comment)

The new plugin includes all existing functionality + much more! (See gem's README: https://github.com/lekemula/solargraph-rspec.)

After you have given it a try and find it worthy, being that rspec is the de-facto preferred testing framework in Ruby, would it make sense to:

  • mention it alongside solargraph-rails in the Readme/Documentation?
  • remove the exclude: ['spec/**/*'] folder as a default config?
    'exclude' => ['spec/**/*', 'test/**/*', 'vendor/**/*', '.bundle/**/*'],

Looking forward to your feedback.

Resolves: #683

@lekemula
Copy link
Contributor Author

remove the exclude: ['spec/**/*'] folder as a default config?

@castwide It turns out that keeping the specs folder in the exclude list, is a good idea. Luckily Solargraph still parses them when opened or changed in the editor, something which I initially thought was a bug, but in our case, it's a very important feature allowing us to "lazy parse" specs 🥳

lekemula/solargraph-rspec@3f0fc39

It's worth mentioning that with this setup, there was no performance issues or degradation whatsoever when testing against Gitlab's codebase.

@castwide
Copy link
Owner

castwide commented Jan 8, 2025

LGTM. Thanks!

@castwide castwide merged commit 9e6ae27 into castwide:master Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSPEC support
2 participants