Adding User Admins to Ping Request from UI #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Morning team, adding a small update to provide the configured public admin keys to the ping API, so that the editor can behave properly when this is configured.
This is a sister PR for cassproject/cass-editor#1363
Issue: Ping API does not currently include the public keys of users who are considered admins for the given CaSS instance.
Security Impact: Users configured as administrators through the environment variables will have admin controls within the CaSS Editor.
Presumptive Impact: Admin functionality will be available to those users in the UI, in addition to simply the API commands which were granted in the previous PR for this.