Adding JWT Awareness to UI Ping #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#issue - Description of changes optionally resulting in changed outcomes.
Currently, the Platform One deployments are not able to use the User Management features of the CaSS editor, due to the CaSS editor removing these features when it detects a public key without OIDC configuration.
This change will allow the "pong" function to return whether its context included auth via the P1 JWT, which will nullify the OIDC components of that check.
The UI portion of this change is here: cassproject/cass-editor#1345
Security Impact: None, as the SSO key would have already needed to pass the other middleware.
Presumptive Impact: This change assumes that the JWT parsing and public key generation are all working as intended.