-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update JSON-RPC API to Condor rc2 #1473
Merged
ipopescu
merged 17 commits into
casper-network:feat-2.0_docs
from
ipopescu:1455_JSON_RPC_rc2
Jun 26, 2024
Merged
Update JSON-RPC API to Condor rc2 #1473
ipopescu
merged 17 commits into
casper-network:feat-2.0_docs
from
ipopescu:1455_JSON_RPC_rc2
Jun 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ACStone-MTS
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Thanks @ACStoneCL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR fix/introduce?
This PR verifies all existing methods and components in the JSON-RPCI API and updates our docs.
I've tested some methods and fields with the casper client and nctl for Condor, but not most. I relied on these files to make the updates:
These files are kept up to date using tests.
I removed the hyperlinks next to the headings of type {#addressableentity} to make the linking work locally for me. I will add them back if needed once I test them in the staging environment. Docusaurus seems to work without them.
I updated the example request/responses to follow the following format:
Request:
Response:
Closes #1455
Checklist
yarn install && yarn run build
.Reviewers
@ACStoneCL