Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JSON-RPC API to Condor rc2 #1473

Merged
merged 17 commits into from
Jun 26, 2024

Conversation

ipopescu
Copy link
Collaborator

@ipopescu ipopescu commented Jun 25, 2024

What does this PR fix/introduce?

This PR verifies all existing methods and components in the JSON-RPCI API and updates our docs.

I've tested some methods and fields with the casper client and nctl for Condor, but not most. I relied on these files to make the updates:

I removed the hyperlinks next to the headings of type {#addressableentity} to make the linking work locally for me. I will add them back if needed once I test them in the staging environment. Docusaurus seems to work without them.

I updated the example request/responses to follow the following format:

Request:

{
  "id": 1,
  "jsonrpc": "2.0",
  "method": “…”,
  "params": [
	...
  ],
}

Response:

{
  "id": 1,
  "jsonrpc": "2.0",
  "result": {
    "name": “…”,
    "value": {
		...
	}
  }  
}

Closes #1455

Checklist

Reviewers

@ACStoneCL

@ipopescu ipopescu requested a review from ACStone-MTS June 25, 2024 21:59
@ipopescu ipopescu marked this pull request as ready for review June 25, 2024 22:00
Copy link
Contributor

@ACStone-MTS ACStone-MTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@ipopescu
Copy link
Collaborator Author

Thanks @ACStoneCL!

@ipopescu ipopescu merged commit 3e317e9 into casper-network:feat-2.0_docs Jun 26, 2024
8 checks passed
@ipopescu ipopescu deleted the 1455_JSON_RPC_rc2 branch June 26, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants