Terminology and Syntax Updates #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a note - I fully expect this build to fail and will need to update a myriad of links once it runs through checks. |
ipopescu
reviewed
May 2, 2024
There was a problem hiding this comment.
This looks good! I have a few questions before approving.
As we discussed, all the put-deploy commands will need rework and until then, we still need to refer to deploys instead of transactions.
Also, the way we query accounts and named keys has changed, so we need to update the commands in “querying-global-state.md” and other instances. But that should be part of a new PR.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR fix/introduce?
This PR begins the process of changing terminology and syntax from 1.0 to 2.0. Mostly, it changes instances of
deploytotransaction, but it also updates some entity related information.Closes #1436
Additional context
This PR does not replace existing tutorials that use
deploysas examples. These will need to be updated slowly at a later date as time and resources allow - all tutorials should still be valid post-Condor, but will use legacy deploys and should be updated as soon as practicable to useput-transactionas appropriate.