specify number of real cores and threads per core #1306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipopescu
approved these changes
Oct 17, 2023
There was a problem hiding this comment.
According to the EC2 user guide, this is correct. Thanks for the updates, @jdpinedac!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR fix/introduce?
Taking into account that on AWS one must consider not only the instance's CPUs but also their equivalence to the vCPUs (virtual CPUs) offered by Amazon instances, the table specifies the equivalent for the recommended instance (t3.2xlarge).
Checklist
yarn install && yarn run build.yarn run check:externals.Reviewers
@bradjohnl @ipopescu