Don't enforce spending limit when delegating with a purse #5011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-casper
commented
Dec 5, 2024
There was a problem hiding this comment.
@EdHastingsCasperAssociation the simple change to the topmost permission check in mint_transfer_direct we discussed on the stand-up wasn't sufficient, as that would result in tons of EE tests failing. The following works, but I'm not sure if it's the correct approach here.
EdHastingsCasperAssociation
approved these changes
Dec 5, 2024
|
bors r+ |
|
Build succeeded: |
casperlabs-bors-ng
bot
merged commit 68be3ff
into
casper-network:feat-2.0
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the behavior whereby the purse used to delegate would be treated as a main purse. This fixes the issue where even though the delegation didn't actually involve the caller’s main purse, the system would still enforce the maximum spending limit for the caller. See: #4999 (comment)