Revert casper ffi change #4842
Closed
Revert casper ffi change #4842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthsiroftardis
requested review from
mpapierski and
EdHastingsCasperAssociation
EdHastingsCasperAssociation
approved these changes
Sep 3, 2024
mpapierski
reviewed
Sep 4, 2024
| @@ -160,9 +160,9 @@ impl ModuleImportResolver for RuntimeModuleImportResolver { | |||
| Signature::new(&[ValueType::I32; 8][..], Some(ValueType::I32)), | |||
| FunctionIndex::CreateContractUserGroup.into(), | |||
| ), | |||
| "casper_add_package_version" => FuncInstance::alloc_host( | |||
| "casper_add_contract_version" => FuncInstance::alloc_host( | |||
| Signature::new(&[ValueType::I32; 11][..], Some(ValueType::I32)), | |||
There was a problem hiding this comment.
I think this will still not solve the issue -> the import statement embedded in already stored contracts have 10 args, but this one has 11 args. We'd perhaps need two host functions?
casper-node/execution_engine/src/core/resolvers/v1_resolver.rs
Lines 163 to 165 in cb932c5
There was a problem hiding this comment.
Ah makes sense, let me just bring back the old FFI
There was a problem hiding this comment.
yeah, you need both the old (for retrograde support) and the new (for go forward)
|
Closing in favor of #4843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG: