Refactor casper-db-utils to make it compatible with casper-node 2.0
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Sardan <[email protected]>
Signed-off-by: Alexandru Sardan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors
casper-db-utilsto make it compatible with the changed in casper-node 2.0 Condor.In fact,
casper-db-utilsnow doesn't depend on the node and performs most of its operations by using the interfaces provided by thecasper-storagecrate.Some of the direct LMDB access was removed in favour of using
casper-storageinterfaces (since technically the LMDB database can be replaced at any time with a different db), however for low level subcommands likecheckthe tool still opens the LMDB database directly and tries to deserialize entries (either through bincode or bytesrepr depending on weather the database in versioned or not).Fixes: #44