Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct logic for SignMessage method #221

Closed
George-cl opened this issue Jan 27, 2022 · 0 comments · Fixed by #239
Closed

Correct logic for SignMessage method #221

George-cl opened this issue Jan 27, 2022 · 0 comments · Fixed by #239
Assignees
@George-cl

Comments

@George-cl
Copy link
Contributor

Metacask reported the following issue and I've repro'd it.

The Signer returns an error if a request is made to sign a message whilst it's locked. It should instead prompt to unlock and then proceed with the signing process as expected.
@George-cl George-cl self-assigned this Jan 27, 2022
@piotrwitek piotrwitek pinned this issue Feb 2, 2022
@piotrwitek piotrwitek unpinned this issue Feb 2, 2022
@piotrwitek piotrwitek pinned this issue Feb 2, 2022
@George-cl George-cl linked a pull request Feb 21, 2022 that will close this issue
Amends Events and SignMessage Logic #239
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@George-cl George-cl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Amends Events and SignMessage Logic casper-ecosystem/signer
2 participants
@devendran-m @George-cl