Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat 3.0 scratch #403

Merged
merged 21 commits into from
Apr 11, 2024
Merged

Feat 3.0 scratch #403

merged 21 commits into from
Apr 11, 2024

Conversation

hoffmannjan
Copy link
Contributor

@hoffmannjan hoffmannjan commented Apr 4, 2024 •
edited by ryo-casper
Loading

Closes #412

@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (feat-3.0@e74c611). Click here to learn what that means.
The diff coverage is 92.88%.

❗ Current head 908b3da differs from pull request most recent head ef9c656. Consider uploading reports for the commit ef9c656 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             feat-3.0     #403   +/-   ##
===========================================
  Coverage            ?   82.54%           
===========================================
  Files               ?       29           
  Lines               ?     1369           
  Branches            ?      145           
===========================================
  Hits                ?     1130           
  Misses              ?      178           
  Partials            ?       61
Components Coverage Δ
@casper-js-sdk/types ∅ <0.00%> (?)
@casper-js-sdk/keys ∅ <0.00%> (?)

@hoffmannjan hoffmannjan changed the base branch from dev to feat-3.0 April 4, 2024 07:38
@ryo-casper ryo-casper self-assigned this Apr 8, 2024
@ryo-casper ryo-casper linked an issue Apr 8, 2024 that may be closed by this pull request
Create project structure for JS SDK v3 #412
Closed
@ryo-casper ryo-casper requested review from zajko and ryo-casper April 8, 2024 02:11
zajko
zajko reviewed Apr 9, 2024
View reviewed changes
packages/keys/assets/ed25519/private_key.pem
@@ -0,0 +1,3 @@
-----BEGIN PRIVATE KEY-----
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are test assets, right? I'm wondering if we could put them in some separate place. I would expect that folder <sub-project>/assets contains files that are needed for the actual compilation and runtime of the project.
This can be done in a later PR though.

zajko
zajko reviewed Apr 9, 2024
View reviewed changes
webpack.config.karma.js Outdated Show resolved Hide resolved
@ryo-casper ryo-casper requested a review from zajko April 10, 2024 00:45
zajko
zajko approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@zajko zajko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

hoffmannjan
hoffmannjan commented Apr 11, 2024
View reviewed changes
codecov.yml
patch:
default:
target: auto
threshold: 5%
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will make it higher value over time ;)

@hoffmannjan hoffmannjan merged commit 301ea78 into feat-3.0 Apr 11, 2024
1 check passed
@ryo-casper ryo-casper deleted the feat-3.0-scratch branch April 11, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zajko zajko zajko approved these changes

@ryo-casper ryo-casper Awaiting requested review from ryo-casper

Assignees

@ryo-casper ryo-casper

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create project structure for JS SDK v3
3 participants
@hoffmannjan @zajko @ryo-casper