Fix List and Map fromBytes parsers

casper-ecosystem · Dec 23, 2024 · b988b0e · b988b0e
1 parent 9a301f2
commit b988b0e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/types/clvalue/List.ts b/src/types/clvalue/List.ts
@@ -163,6 +163,10 @@ export class CLValueList {
           bytes: innerBytes
         } = CLValueParser.fromBytesByType(remainder, clType.elementsType);
 
+        if (!inner) {
+          continue;
+        }
+
         elements.push(inner);
         remainder = innerBytes;
       }

diff --git a/src/types/clvalue/Map.ts b/src/types/clvalue/Map.ts
@@ -195,7 +195,7 @@ export class CLValueMap {
 
     const { result: u32, bytes: u32Bytes } = CLValueUInt32.fromBytes(bytes);
     const size = u32.getValue().toNumber();
-    let remainder = u32Bytes;
+    const remainder = u32Bytes;
 
     if (size === 0) {
       return { result: mapResult, bytes: remainder };
@@ -205,11 +205,15 @@ export class CLValueMap {
       if (remainder.length) {
         const keyVal = CLValueParser.fromBytesByType(remainder, mapType.key);
 
-        remainder = keyVal?.bytes;
+        if (!keyVal.result) {
+          continue;
+        }
 
         const valVal = CLValueParser.fromBytesByType(remainder, mapType.val);
 
-        remainder = valVal.bytes;
+        if (!valVal.result) {
+          continue;
+        }
 
         mapResult.append(keyVal?.result, valVal?.result);
       }