Remove vergen dep on feat-track-2.0 for cargo audit #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tem#175 Part of casper-ecosystem#144 Enable CI CD check on feat-track-2.0
Closed
gRoussac
added a commit
that referenced
this pull request
Jul 18, 2024
jacek-casper
approved these changes
Aug 28, 2024
gRoussac
merged commit 2227d5a
into
casper-ecosystem:feat-track-node-2.0
1 check passed
gRoussac
added a commit
that referenced
this pull request
Oct 21, 2024
* Removing wrap_help + sdk feat * Removing multi-thread * schemars bug * update * move node to ecosystem from Fraser branch * Update cargo * Expose cli to sdk * Try to load pem key from string * Return deploys for make_transfer make_deploy * Expose simple_args::insert_arg * little change * Missing flag * Remove flag * small change * Expose json args * Add doc * Unreachable on simple args + json args * Add check_exactly_one_args_type_not_empty to parse.rs * no args is valid ! * changing name * ConflictingArguments to context: String * little clone on DictionaryItemIdentifierget * Hacking parse for sdk deploy module bytes * Fix import and sdk * parse purse identifier * session_bytes * Add some clone * remove call rpc pretty printed to std in sdk * Update for account identifier * update types to feat 2.0 * Missing dep ? * revert * Remove json-schema * getrandom js only for sdk feature * getrandom was removed * Cargo doc * Sort back use in parse.rs * Duplicate get_maybe_secret_key * Update cli.rs Change import JsonArg * Update Cargo.toml * branch update * update types * revert * Merge back changes for std-fs-io * build without feature * Update schemars * Expose new error and add_arg * Update cargo-toml * Revert * Revert * test compilation * add branch ? * test * test * Revert * revert * pub entity_identifier * pub EntityOrAccount * add methods to GetAddressableEntityResult * small change * test * test GetAddressableEntityResult * Wrap casper types AddressableEntity in GetAddressableEntityResult * wrap EntityOrAccount methods * Clone values * pub * revert * try alias * Clone * Clone * Clone on QueryBalanceDetailsResult * Clone * Add gate to from_file in parse * clone + typo * Clone * Expose transfer_target * import * Typo * clone * pub pricing_mode * revert * Debug * test * test * test * test * test * revert * Revert * revert * test * test * test * test * test * test * testing * testing * test * test * revert timestamp bug * Typo in doc * Review fixes * Clippy * clippy ? * clippy * Rework code comments * syntax avoid if/elseif/else * Update ci-cd file as per #185 * toolchain * Port #185 * clippy * Change test error string * Tests in std-fs-io * Cargo doc * Expose SpeculativeExecutionResult * test package bug * test failing * compile * Update cargo toml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to have Ci/CD and cargo audit passing on feat-track-2.0. I suggest we cherry-pick some changes from dev to remove vergen, prepare code verification changes and for now still bypass "std-fs-io" feature
devbranch toolchain issues. #149 #163 Handle git dependency in build.rs #175 and partially Interaction with Casper smart-contract source code verification service #144 to remove vergen and set tokio as depstd-fs-ioin casper-types for wasm compilation casper-network/casper-node#4714 are merged