Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUT-06: add icon URL #604

Merged
merged 6 commits into from
Sep 8, 2024
Merged

NUT-06: add icon URL #604

merged 6 commits into from
Sep 8, 2024

Conversation

callebtc
Copy link
Collaborator

Implements cashubtc/nuts#130

Copy link
Contributor

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update to reflect comment cashubtc/nuts#130 (comment)

cashu/core/models.py Outdated Show resolved Hide resolved
cashu/wallet/mint_info.py Outdated Show resolved Hide resolved
cashu/core/settings.py Outdated Show resolved Hide resolved
cashu/mint/router.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.10%. Comparing base (8675745) to head (d95f680).
Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8675745) and HEAD (d95f680). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (8675745) HEAD (d95f680)
9 3
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #604      +/-   ##
==========================================
- Coverage   69.02%   59.10%   -9.92%     
==========================================
  Files          92       97       +5     
  Lines        8674    10388    +1714     
==========================================
+ Hits         5987     6140     +153     
- Misses       2687     4248    +1561     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit ef5aee9 into main Sep 8, 2024
19 checks passed
@callebtc callebtc deleted the mint-icon branch September 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants