Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Nut 05 mint response model #564

Merged
merged 5 commits into from
Jun 27, 2024
Merged

Fix: Nut 05 mint response model #564

merged 5 commits into from
Jun 27, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Jun 26, 2024

Change response model according to cashubtc/nuts#136

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.28%. Comparing base (1766b6e) to head (ce6f1a2).
Report is 3 commits behind head on main.

Current head ce6f1a2 differs from pull request most recent head d3568e5

Please upload reports for the commit d3568e5 to get more accurate results.

Files Patch % Lines
cashu/core/base.py 71.42% 2 Missing ⚠️
cashu/mint/ledger.py 71.42% 2 Missing ⚠️
cashu/mint/router.py 0.00% 2 Missing ⚠️
cashu/mint/router_deprecated.py 0.00% 1 Missing ⚠️
cashu/wallet/v1_api.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
- Coverage   65.02%   64.28%   -0.74%     
==========================================
  Files          91       91              
  Lines        8065     8080      +15     
==========================================
- Hits         5244     5194      -50     
- Misses       2821     2886      +65     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 1d8b5cd into main Jun 27, 2024
11 checks passed
@callebtc callebtc deleted the nut-05-mint-response-model branch June 27, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant