Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mint] Add support for BTC and EUR in StrikeWallet backend, add EUR to FakeWallet #561

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Jun 25, 2024

This pull request adds support for EUR in the Strike backend. Previously, only USD was supported. With this change, users will be able to use Strike for BTC, USD, and EUR.

  • Configuration in .env changes from StrikeUSDWallet to StrikeWallet
  • FakeWallet now supports EUR as well
  • Invoice listener only for backends that support incoming payment streams
  • Invoice listener now restarts on error

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

Attention: Patch coverage is 42.55319% with 27 lines in your changes missing coverage. Please review.

Project coverage is 68.72%. Comparing base (3b2f1aa) to head (103cc0a).
Report is 17 commits behind head on main.

Current head 103cc0a differs from pull request most recent head 772fb26

Please upload reports for the commit 772fb26 to get more accurate results.

Files Patch % Lines
cashu/core/base.py 25.92% 20 Missing ⚠️
cashu/lightning/strike.py 50.00% 4 Missing ⚠️
cashu/mint/startup.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #561      +/-   ##
==========================================
- Coverage   69.62%   68.72%   -0.90%     
==========================================
  Files          76       91      +15     
  Lines        6913     7965    +1052     
==========================================
+ Hits         4813     5474     +661     
- Misses       2100     2491     +391     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daveajones
Copy link

Thank you for this. Was just trying to get this working today. 🙏🙏

@callebtc callebtc changed the title "Add support for EUR in Strike backend" [Mint] Add support for BTC and EUR in Strike backend Jun 26, 2024
@callebtc callebtc changed the title [Mint] Add support for BTC and EUR in Strike backend [Mint] Add support for BTC and EUR in StrikeWallet backend, add EUR to FakeWallet Jun 26, 2024
@callebtc callebtc merged commit 1766b6e into main Jun 26, 2024
11 checks passed
@callebtc callebtc deleted the mint-strike-btc-euro branch June 26, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants