Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mint: refactor melt quote #530

Merged
merged 1 commit into from
May 22, 2024
Merged

Mint: refactor melt quote #530

merged 1 commit into from
May 22, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented May 12, 2024

Remove option to skip checking payment state in get_melt_quote and always check it if unpaid.

Todo: check if the melt routine assumed that it would skip the check in order to avoid double-checking. If so, remove duplicate check in melt routine.

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.83%. Comparing base (3b2f1aa) to head (ed8b8fb).
Report is 9 commits behind head on main.

Files Patch % Lines
cashu/mint/router.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
- Coverage   69.62%   65.83%   -3.79%     
==========================================
  Files          76       76              
  Lines        6913     6958      +45     
==========================================
- Hits         4813     4581     -232     
- Misses       2100     2377     +277     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 71b4051 into main May 22, 2024
16 checks passed
@callebtc callebtc deleted the refactor-melt-quote branch May 22, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant