Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: melt quote unit validation #489

Merged
merged 6 commits into from
Mar 23, 2024
Merged

Refactor: melt quote unit validation #489

merged 6 commits into from
Mar 23, 2024

Conversation

callebtc
Copy link
Collaborator

No description provided.

@callebtc callebtc changed the title Refactor: melt quote validation Refactor: melt quote amount unit validation Mar 22, 2024
@callebtc callebtc changed the title Refactor: melt quote amount unit validation Refactor: melt quote unit validation Mar 22, 2024
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.81%. Comparing base (3ba1e81) to head (1717d4c).

Files Patch % Lines
cashu/mint/ledger.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   67.69%   65.81%   -1.89%     
==========================================
  Files          74       74              
  Lines        6758     6760       +2     
==========================================
- Hits         4575     4449     -126     
- Misses       2183     2311     +128     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit b288a6d into main Mar 23, 2024
16 checks passed
@callebtc callebtc deleted the fakewallet-usd-fixes branch March 23, 2024 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant