Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PostRestoreResponse class to use "signatures" instead of "promises" #467

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Mar 4, 2024

This pull request updates the PostRestoreResponse class in order to use the "signatures" attribute instead of the deprecated "promises" attribute. This change ensures backwards compatibility with old clients and improves code clarity.

Implement change in cashubtc/nuts#87

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.86%. Comparing base (7257386) to head (40aea2d).
Report is 1 commits behind head on main.

Files Patch % Lines
cashu/mint/router.py 0.00% 1 Missing ⚠️
cashu/mint/router_deprecated.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #467      +/-   ##
==========================================
+ Coverage   68.83%   68.86%   +0.02%     
==========================================
  Files          74       74              
  Lines        6633     6641       +8     
==========================================
+ Hits         4566     4573       +7     
- Misses       2067     2068       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 4f52973 into main Mar 12, 2024
16 checks passed
@callebtc callebtc deleted the nut-09-update-endpoint branch March 12, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant