add missing disabled-flag to nut4 #426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #426 +/- ##
==========================================
- Coverage 68.79% 68.77% -0.02%
==========================================
Files 73 73
Lines 6441 6447 +6
==========================================
+ Hits 4431 4434 +3
- Misses 2010 2013 +3 ☔ View full report in Codecov by Sentry. |
callebtc
reviewed
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the current spec the nut4 info-response provided by nutshell is missing the disabled-flag
https://github.com/cashubtc/nuts/blob/main/04.md
BTW nutshell is providing a disabled flag for nut5, which is not part of the spec. This is not a problem for a client, because additional information in the json is ignored, but I think this is an error in the spec. The mint runner should have the option to disable minting and melting.