Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mint: add seed decrypt #403

Merged
merged 2 commits into from
Feb 5, 2024
Merged

mint: add seed decrypt #403

merged 2 commits into from
Feb 5, 2024

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Feb 2, 2024

Todo:

  • migrate seeds in db to encrypted seeds with migration tool
  • store seed in db only if encrypted: no
  • decrypt seed from db

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 81 lines in your changes are missing coverage. Please review.

Comparison is base (30b6e8a) 69.30% compared to head (209b61b) 68.77%.

Files Patch % Lines
cashu/mint/decrypt.py 0.00% 76 Missing ⚠️
cashu/core/base.py 90.90% 2 Missing ⚠️
cashu/core/crypto/aes.py 95.23% 2 Missing ⚠️
cashu/core/settings.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #403      +/-   ##
==========================================
- Coverage   69.30%   68.77%   -0.53%     
==========================================
  Files          71       73       +2     
  Lines        6206     6348     +142     
==========================================
+ Hits         4301     4366      +65     
- Misses       1905     1982      +77     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc marked this pull request as ready for review February 4, 2024 18:38
@callebtc callebtc merged commit e02e4bb into main Feb 5, 2024
11 checks passed
@callebtc callebtc deleted the mint-encrypt-seed branch February 5, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant