Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/mint_add_verification_balance #373

Merged
merged 3 commits into from
Dec 2, 2023

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Dec 2, 2023

Split method invalidates proofs now only if all verifications pass and as the last step before generating new promises.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (bb51567) 66.29% compared to head (861ffa6) 66.11%.

Files Patch % Lines
cashu/mint/ledger.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   66.29%   66.11%   -0.19%     
==========================================
  Files          68       68              
  Lines        5219     5220       +1     
==========================================
- Hits         3460     3451       -9     
- Misses       1759     1769      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 0ec3af9 into main Dec 2, 2023
8 of 9 checks passed
@callebtc callebtc deleted the test/mint_add_verification_balance branch December 2, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant