Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cast keyset keys (amount) to int #368

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Conversation

callebtc
Copy link
Collaborator

Fixed loading keysets from the database that were read as strings and lead to wrong keyset ID calculation, since strings are ordered differently than ints.

Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b519c7d) 66.00% compared to head (037d977) 66.00%.

Files Patch % Lines
cashu/wallet/wallet.py 60.00% 2 Missing ⚠️
cashu/core/base.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #368   +/-   ##
=======================================
  Coverage   66.00%   66.00%           
=======================================
  Files          68       68           
  Lines        5160     5166    +6     
=======================================
+ Hits         3406     3410    +4     
- Misses       1754     1756    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit f7d0126 into main Nov 24, 2023
9 checks passed
@callebtc callebtc deleted the fix_key_loading_integer branch November 24, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant