Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix LNbits backend to use proper BaseModels #352

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Nov 1, 2023

LNbits backend now responds with correct pydantic basemodels, instead of namedtuples before.

Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (22e0ad4) 68.16% compared to head (eb4ed63) 68.17%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
+ Coverage   68.16%   68.17%   +0.01%     
==========================================
  Files          65       65              
  Lines        4821     4820       -1     
==========================================
  Hits         3286     3286              
+ Misses       1535     1534       -1     
Files Coverage Δ
cashu/lightning/fake.py 78.94% <100.00%> (ø)
cashu/lightning/lnbits.py 15.71% <5.00%> (+0.22%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit aa36651 into main Nov 1, 2023
9 checks passed
@callebtc callebtc deleted the fix/lnbits_status_response branch November 1, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant