Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor secret conditions #350

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Refactor secret conditions #350

merged 2 commits into from
Oct 21, 2023

Conversation

callebtc
Copy link
Collaborator

More rigid structure in validation and full documentation of all steps for P2PK input and output checking, and for HTLC input checking.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Attention: 78 lines in your changes are missing coverage. Please review.

Comparison is base (0490f20) 68.17% compared to head (305598b) 68.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #350      +/-   ##
==========================================
- Coverage   68.17%   68.16%   -0.02%     
==========================================
  Files          65       65              
  Lines        4817     4821       +4     
==========================================
+ Hits         3284     3286       +2     
- Misses       1533     1535       +2     
Files Coverage Δ
cashu/core/secret.py 100.00% <100.00%> (ø)
cashu/wallet/htlc.py 88.46% <ø> (ø)
cashu/wallet/p2pk.py 100.00% <100.00%> (ø)
cashu/core/htlc.py 63.63% <0.00%> (ø)
cashu/core/p2pk.py 59.61% <87.50%> (+1.61%) ⬆️
cashu/core/base.py 93.91% <0.00%> (+0.65%) ⬆️
cashu/mint/conditions.py 21.55% <15.11%> (-0.07%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 48f732e into main Oct 21, 2023
9 checks passed
@callebtc callebtc deleted the refactor_secret_conditions branch October 21, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant