Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Add nostr dependency directly to repo #346

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

callebtc
Copy link
Collaborator

For nix.

@callebtc callebtc added wallet About the Nutshell wallet code health Code health deployment Related to deploying Cashu labels Oct 15, 2023
@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

Attention: 341 lines in your changes are missing coverage. Please review.

Comparison is base (21bb42f) 70.20% compared to head (a853c80) 67.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #346      +/-   ##
==========================================
- Coverage   70.20%   67.97%   -2.24%     
==========================================
  Files          51       63      +12     
  Lines        4085     4834     +749     
==========================================
+ Hits         2868     3286     +418     
- Misses       1217     1548     +331     
Files Coverage Δ
cashu/wallet/api/router.py 70.61% <100.00%> (ø)
cashu/wallet/cli/cli.py 60.48% <100.00%> (ø)
cashu/nostr/message_type.py 92.30% <92.30%> (ø)
cashu/nostr/subscription.py 57.14% <57.14%> (ø)
cashu/nostr/delegation.py 80.00% <80.00%> (ø)
cashu/nostr/event.py 89.85% <89.85%> (ø)
cashu/nostr/relay_manager.py 83.33% <83.33%> (ø)
cashu/wallet/nostr.py 40.50% <26.66%> (-2.36%) ⬇️
cashu/nostr/client/cbc.py 48.00% <48.00%> (ø)
cashu/nostr/message_pool.py 48.14% <48.14%> (ø)
... and 6 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc mentioned this pull request Oct 15, 2023
@callebtc callebtc merged commit a76f076 into main Oct 15, 2023
9 checks passed
@callebtc callebtc deleted the include_nostr_client branch October 15, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Code health deployment Related to deploying Cashu wallet About the Nutshell wallet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant