Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallet] Fix fee return for fee=0 #345

Merged
merged 1 commit into from
Oct 15, 2023
Merged

Conversation

callebtc
Copy link
Collaborator

fees were not returned if the fees were zero

@codecov
Copy link

codecov bot commented Oct 15, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a7cc210) 70.15% compared to head (bae5f83) 70.20%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #345      +/-   ##
==========================================
+ Coverage   70.15%   70.20%   +0.04%     
==========================================
  Files          51       51              
  Lines        4085     4085              
==========================================
+ Hits         2866     2868       +2     
+ Misses       1219     1217       -2     
Files Coverage Δ
cashu/mint/ledger.py 79.07% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc merged commit 21bb42f into main Oct 15, 2023
9 checks passed
@callebtc callebtc deleted the wallet/fix_fee_reserve_for_fee_0 branch October 15, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant