Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nutshell cleanup wishlist #332

Merged
merged 179 commits into from
Jan 7, 2024

clean up literals

9cfc2f7
Select commit
Loading
Failed to load commit list.
Merged

Nutshell cleanup wishlist #332

clean up literals
9cfc2f7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2024 in 0s

68.76% (+2.06%) compared to 375b278

View this Pull Request on Codecov

68.76% (+2.06%) compared to 375b278

Details

Codecov Report

Attention: 497 lines in your changes are missing coverage. Please review.

Comparison is base (375b278) 66.70% compared to head (9cfc2f7) 68.76%.
Report is 1 commits behind head on main.

Files Patch % Lines
cashu/mint/router_deprecated.py 0.00% 115 Missing ⚠️
cashu/lightning/strike.py 16.12% 78 Missing ⚠️
cashu/mint/router.py 0.00% 76 Missing ⚠️
cashu/wallet/cli/cli.py 55.12% 35 Missing ⚠️
cashu/wallet/cli/cli_helpers.py 23.80% 32 Missing ⚠️
cashu/core/logging.py 15.62% 27 Missing ⚠️
cashu/mint/ledger.py 89.44% 23 Missing ⚠️
cashu/core/base.py 89.57% 22 Missing ⚠️
cashu/wallet/wallet.py 94.27% 13 Missing ⚠️
cashu/lightning/fake.py 47.61% 11 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #332      +/-   ##
==========================================
+ Coverage   66.70%   68.76%   +2.06%     
==========================================
  Files          68       71       +3     
  Lines        5241     6163     +922     
==========================================
+ Hits         3496     4238     +742     
- Misses       1745     1925     +180     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.