Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet: fix secret derivation & new CLI command cashu selfpay #331

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

callebtc
Copy link
Collaborator

@callebtc callebtc commented Oct 3, 2023

Removes the unnecessary hashing in the secret derivation.

Note: old tokens can't be restored after this upgrade. Self-payment is necessary to be able to restore all tokens again.

Use: new CLI command cashu selfpay to recycle tokens once.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (0959314) 68.94% compared to head (7e60410) 69.23%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #331      +/-   ##
==========================================
+ Coverage   68.94%   69.23%   +0.28%     
==========================================
  Files          52       52              
  Lines        4193     4212      +19     
==========================================
+ Hits         2891     2916      +25     
+ Misses       1302     1296       -6     
Files Coverage Δ
cashu/wallet/cli/cli_helpers.py 52.83% <100.00%> (+18.86%) ⬆️
cashu/wallet/secrets.py 91.35% <100.00%> (ø)
cashu/wallet/wallet.py 89.25% <ø> (ø)
cashu/wallet/cli/cli.py 58.63% <89.47%> (+1.30%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callebtc callebtc changed the title Wallet: fix secret derivation Wallet: fix secret derivation & new CLI command cashu selfpay Oct 3, 2023
@callebtc callebtc merged commit 1149533 into main Oct 3, 2023
@callebtc callebtc deleted the refactor/wallet_restore_tests branch October 3, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant