-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REFACTOR] use bolt11 library #297
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
==========================================
- Coverage 68.94% 59.01% -9.93%
==========================================
Files 52 42 -10
Lines 4189 3809 -380
==========================================
- Hits 2888 2248 -640
- Misses 1301 1561 +260
☔ View full report in Codecov by Sentry. |
df528d7
to
4f1d615
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I've not tested though)
@@ -2,9 +2,14 @@ | |||
import hashlib | |||
import random | |||
from datetime import datetime | |||
from typing import AsyncGenerator, Dict, Optional, Set | |||
from os import urandom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recently noticed that the secrets
module exists, may be 'more ideomatic' to use that?
refactored to use https://pypi.org/project/bolt11/