Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] use bolt11 library #297

Closed
wants to merge 6 commits into from
Closed

[REFACTOR] use bolt11 library #297

wants to merge 6 commits into from

Conversation

dni
Copy link
Collaborator

@dni dni commented Aug 7, 2023

@dni dni requested a review from callebtc August 7, 2023 20:23
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 26.47% and project coverage change: -9.93% ⚠️

Comparison is base (64805e4) 68.94% compared to head (2988c43) 59.01%.

❗ Current head 2988c43 differs from pull request most recent head aebbe6b. Consider uploading reports for the commit aebbe6b to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #297      +/-   ##
==========================================
- Coverage   68.94%   59.01%   -9.93%     
==========================================
  Files          52       42      -10     
  Lines        4189     3809     -380     
==========================================
- Hits         2888     2248     -640     
- Misses       1301     1561     +260     
Files Changed Coverage Δ
cashu/mint/ledger.py 28.17% <20.00%> (-50.97%) ⬇️
cashu/lightning/fake.py 41.81% <24.00%> (-39.04%) ⬇️
cashu/wallet/wallet.py 80.62% <50.00%> (-8.63%) ⬇️

... and 26 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dni dni force-pushed the bolt11 branch 2 times, most recently from df528d7 to 4f1d615 Compare August 24, 2023 08:21
Copy link
Collaborator

@AngusP AngusP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (I've not tested though)

@@ -2,9 +2,14 @@
import hashlib
import random
from datetime import datetime
from typing import AsyncGenerator, Dict, Optional, Set
from os import urandom
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recently noticed that the secrets module exists, may be 'more ideomatic' to use that?

cashu/mint/ledger.py Outdated Show resolved Hide resolved
@callebtc callebtc mentioned this pull request Oct 15, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants