[WIP] [NUTs] NUT-06 update: deprecate amount field in /split
#263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2023
AngusP
reviewed
Jul 4, 2023
| @@ -862,9 +857,9 @@ async def check_fees(self, pr: str): | |||
| async def split( | |||
There was a problem hiding this comment.
Changing order of kwargs, safter to add the 'magic' asterisk?
async def split(
self,
*,
...
):to force calling with kwargs?
cashu/mint/ledger.py
Outdated
Comment on lines
923
to
925
| prom_fst, prom_snd = await self._generate_promises( | ||
| B_fst, keyset | ||
| ), await self._generate_promises(B_snd, keyset) |
There was a problem hiding this comment.
Just for readability, doesn't need to be a tuple that then gets decomposed anyway
Suggested change
| prom_fst, prom_snd = await self._generate_promises( | |
| B_fst, keyset | |
| ), await self._generate_promises(B_snd, keyset) | |
| prom_fst = await self._generate_promises(B_fst, keyset) | |
| prom_snd = await self._generate_promises(B_snd, keyset) |
callebtc
force-pushed
the
nut06/no_amount_in_split
branch
from
eb0541e to
1ca9b17
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 56.59% 56.44% -0.16%
==========================================
Files 43 43
Lines 3963 3974 +11
==========================================
Hits 2243 2243
- Misses 1720 1731 +11
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses cashubtc/nuts#34
Makes the code so much better to read.