Payment Method Refactor #201
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purpleKarrot
suggested changes
Dec 14, 2024
| "unit": <str_enum["sat"]>, | ||
| "description": <str|null> | ||
| "unit": <str>, | ||
| "opts": <obj|null> |
There was a problem hiding this comment.
I am in favor of the change, but strictly speaking it is a breaking change.
|
|
||
| ```bash | ||
| curl -X POST http://localhost:3338/v1/mint/quote/bolt11 -d '{"amount": 10, "unit": "sat"}' -H "Content-Type: application/json" | ||
| curl -X POST https://mint.host:3338/v1/mint/quote/{method} \ |
There was a problem hiding this comment.
Here, using bolt11 should be preferred over {method}, because it is an example and other variables have concrete values too (10 and sat).
|
|
||
| ```bash | ||
| curl -X GET http://localhost:3338/v1/mint/quote/bolt11/DSGLX9kevM... | ||
| curl -X GET https://mint.host:3338/v1/mint/quote/{method}/{quote_id} |
There was a problem hiding this comment.
Again, use concrete values in an example.
|
|
||
| ```bash | ||
| curl -X POST https://mint.host:3338/v1/mint/bolt11 -H "Content-Type: application/json" -d \ | ||
| '{ | ||
| curl -X POST https://mint.host:3338/v1/mint/{method} \ |
|
|
||
| ```bash | ||
| curl -X POST https://mint.host:3338/v1/melt/quote/bolt11 -d \ | ||
| { | ||
| curl -X POST https://mint.host:3338/v1/melt/quote/{method} -d \ |
|
|
||
| ```bash | ||
| curl -X GET http://localhost:3338/v1/melt/quote/bolt11/TRmjduhIsPxd... | ||
| curl -X GET https://mint.host:3338/v1/melt/quote/{method}/{quote_id} |
|
|
||
| ```bash | ||
| curl -X POST https://mint.host:3338/v1/melt/bolt11 -d \ | ||
| curl -X POST https://mint.host:3338/v1/melt/{method} -d \ |
|
|
||
| ```json | ||
| { | ||
| "quote": <str>, | ||
| "inputs": <Array[Proof]>, | ||
| "outputs": <Array[BlindedMessage]> <-- New | ||
| "outputs": <Array[BlindedMessage]> |
There was a problem hiding this comment.
What is the rationale for dropping the <-- New comment?
| "payment_preimage": <str|null>, | ||
| "change": <Array[BlindSignature]> <-- New | ||
| "change": <Array[BlindSignature]> |
|
|
||
| ```bash | ||
| curl -X POST https://mint.host:3338/v1/melt/bolt11 -d \ | ||
| curl -X POST https://mint.host:3338/v1/melt/{method} -d \ |
There was a problem hiding this comment.
Again, use concrete values in examples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.