-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spec for binary token serialization #199
Conversation
I am not a big fan of this proposal because it requires cbor dependency for future versions which might not be based on cbor. IMO much better encoding is just simple:
(where binary data is the data just before base64 encoding) That way an app can very simply check whether it understands the payload by checking the first 5 bytes. Also I think that we should use binary version 03 for v3 of token and 04 for v4 token. |
Very good point, however this is meant to be for transports that are binary only. So we should probably do something like
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This adds some standardization for upcoming raw / binary token serialization, simply prepending the token with a identifier, as well as a version "byte" and encoding everything using
cbor
.