error code for failed lightning payments #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed nutshell also has a general lightning error 20000 not sure what its used for? Should that be added as well, or is the only error we want to return a payment failed? |
|
I've seen it but not sure either how it's used since there can be different errors with the lightning backend. Maybe @callebtc can add to that. I only thought of payment failure error as a way for wallets to know for sure that the payment failed so they can use those proofs in other ops and are not stuck. But feel free to add other errors that you think would apply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add error code for failed lightning payments in melts. If wallets see this error they can be sure the proofs are not stuck in a pending state.