make nut06 fields optional #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
reviewed
Aug 31, 2024
| - `modt` is the message of the day that the wallet must display to the user. It should only be used to display important announcements to users, such as scheduled maintenances. | ||
| - `nuts` indicates each NUT specification that the mint supports and its settings. The settings are defined in each NUT separately. | ||
| - (optional) `name` is the name of the mint and should be recognizable. | ||
| - (optional) `pubkey` is the hex pubkey of the mint. |
There was a problem hiding this comment.
isn't at least the pubkey mandatory?
There was a problem hiding this comment.
Nope, this pubkey isn't used for anything productive yet. The relevant ecash pubkeys are found in /v1/keys
prusnak
reviewed
Aug 31, 2024
06.md
Outdated
| - `contact` is an array of contact objects to reach the mint operator. A contact object consists of two fields. The `method` field denotes the contact method (like "email"), the `info` field denotes the identifier (like "[email protected]"). | ||
| - `modt` is the message of the day that the wallet must display to the user. It should only be used to display important announcements to users, such as scheduled maintenances. | ||
| - `nuts` indicates each NUT specification that the mint supports and its settings. The settings are defined in each NUT separately. | ||
| - (optional) `name` is the name of the mint and should be recognizable. |
There was a problem hiding this comment.
maybe we should make the name mandatory too?
There was a problem hiding this comment.
I think at the spec level we should leave it optional so its not relied on for serialization but implementation should strongly encourage setting one.
callebtc
approved these changes
Sep 2, 2024
| - `modt` is the message of the day that the wallet must display to the user. It should only be used to display important announcements to users, such as scheduled maintenances. | ||
| - `nuts` indicates each NUT specification that the mint supports and its settings. The settings are defined in each NUT separately. | ||
| - (optional) `name` is the name of the mint and should be recognizable. | ||
| - (optional) `pubkey` is the hex pubkey of the mint. |
There was a problem hiding this comment.
Nope, this pubkey isn't used for anything productive yet. The relevant ecash pubkeys are found in /v1/keys
prusnak
approved these changes
Sep 2, 2024
thesimplekid
force-pushed
the
nut06_optional
branch
from
e80b6a4 to
4ac9433
Compare
thesimplekid
force-pushed
the
nut06_optional
branch
from
4ac9433 to
681103d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.