Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NUT-18: Payment Requests #124
NUT-18: Payment Requests #124
Changes from 23 commits
b7b0781
b12b4ee
9021c09
0e9b53d
80e6d6f
50fc922
1632d88
0c57a0d
183d2bb
3349e24
ec0cb4e
64dc463
5734943
40ec76b
0f4ddc2
28e6f9f
459d66f
4989f52
ec3bfa3
0663344
a2c6172
1c1050d
211864c
4ec6ec7
8002b5b
09d70ec
c09e45f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be helpful to indicate in the Flow at which point user interaction or confirmation is needed (from the payer side), and if there is anything the app must / should show to the user before confirmation, similar to LNURL-pay / LNURL-withdraw.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which are the transport types? Looks like a list was intended here, but missing.