Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add amount to nut05 #173

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Oct 9, 2024

In order to support paying an amount-less invoice, add amount to quote request.

closes #172

In order to support paying an amountless invoice,
add amount to quote request.
@prusnak
Copy link
Collaborator

prusnak commented Oct 9, 2024

I think we should specify whether amount can be provided if bolt11 invoice contains an amount.

There are 3 options:
a) amount must not be provided
b) amount can be provided but is ignored
c) amount can be provided but must match the amount in bolt11 invoice

I like the C option the most.

05.md Outdated Show resolved Hide resolved
@thesimplekid
Copy link
Collaborator Author

I think we should specify whether amount can be provided if bolt11 invoice contains an amount.

Good point, I've updated wording to reflect this.

@callebtc
Copy link
Contributor

Setting for the info endpoint (some backends can't pay amountless invoices)

@thesimplekid
Copy link
Collaborator Author

Setting for the info endpoint (some backends can't pay amountless invoices)

Added in 6628ff1

05.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-ACK after the new changes

05.md Outdated Show resolved Hide resolved
05.md Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support paying amountless invoices
4 participants