Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MintInfo method for amountless #225

Open
Egge21M opened this issue Dec 12, 2024 · 4 comments
Open

Add MintInfo method for amountless #225

Egge21M opened this issue Dec 12, 2024 · 4 comments

Comments

@Egge21M
Copy link
Collaborator

Egge21M commented Dec 12, 2024

See: cashubtc/nuts#173

@mubarak23
Copy link

@Egge21M is anybody working on this, if not, i will work on it.

@Egge21M
Copy link
Collaborator Author

Egge21M commented Dec 17, 2024

@Egge21M is anybody working on this, if not, i will work on it.

Not that I know of, feel free to take this on. Thank you for your initiative!

@mubarak23
Copy link

mubarak23 commented Dec 23, 2024

if i understand the cashubtc/nuts#173 correctly, bunch of work to support amountless invoice will be handle by the mint, but here our createMeltQuote will accept an optional field, then check if the mint support amountless invoice, if YES, we refactor the MeltQuotePayload to have this

"options": { // Optional
    "amountless": {
      "amount_msat": <int>
    }

or better still, have a new method that handle amountless melt quote seperate from createMeltQuote
@Egge21M am correct here

@Egge21M
Copy link
Collaborator Author

Egge21M commented Dec 23, 2024

if i understand the cashubtc/nuts#173 correctly, bunch of work to support amountless invoice will be handle by the mint, but here our createMeltQuote will accept an optional field, then check if the mint support amountless invoice, if YES, we refactor the MeltQuotePayload to have this

"options": { // Optional
    "amountless": {
      "amount_msat": <int>
    }

or better still, have a new method that handle amountless melt quote seperate from createMeltQuote @Egge21M am correct here

I think it is fine to have it in one method, as it does not require an additional parameter. However the MintInfo class should be extended by a method to check wether this is supported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants