Skip to content

Commit

Permalink
apply review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
callebtc committed Dec 3, 2024
1 parent 9d172de commit 2e99618
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion xx+1.md
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ Like in [NUT-04][04], the wallet includes a `PostAuthBlindMintRequest` in the re
}
```

where `outputs` are `BlindedMessages` (see [NUT-00][00]) from the blind auth keyset of the mint with a unit `amount`. The sum of all amounts of the outputs cannot exceed the maximum allowed amount of BATs as specified in `max_mint` in the mint's `MintBlindAuthSetting` (see **TODO: Add ref**)
where `outputs` are `BlindedMessages` (see [NUT-00][00]) from the blind auth keyset of the mint with a unit `amount`. The sum of all amounts of the outputs cannot exceed the maximum allowed amount of BATs as specified in `bat_max_mint` in the mint's `MintBlindAuthSetting` (see **TODO: Add ref**)

Notice that in contrast to [NUT-04][04], we did not create a quote and did not include it in this request. Instead, we directly minted the maximum allowed amount of BATs.

Expand Down
7 changes: 5 additions & 2 deletions xx.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ This NUT defines a clear authentication scheme that allows mint operators to lim

The OpenID Connect (OIDC) service is typically run by the mint operator (but it does not have to be). The OIDC service must be configured to meet the following criteria:

- **Client ID:** The OIDC service MUST enable the client ID `cashu-client`, which is shared by all authenticating wallets.
- **Client ID:** The OIDC service announces the client ID that wallets should use to authenticate. The OIDC service SHOULD add a client with ID `cashu-client`.
- **Signature algorithm:** The OIDC service MUST support at least one of the two asymmetric JWS signature algorithms for access token and ID token signatures: `ES256` and `RS256`.
- **Wallet redirect URLs:** To support the OpenID Connect Authorization Code flow, the OIDC service MUST allow redirect URLs that correspond to the wallets it wants to support. You can find a list of common redirect URLs for well-known Cashu wallets [here][XX-SUPPL].
- **Localhost redirect URL:** The OIDC service MUST also allow redirects to the URL `http://localhost:33388/callback`.
Expand All @@ -31,6 +31,7 @@ The mint lists each protected endpoint that requires a clear authentication toke
```json
"XX" : {
"openid_discovery": "https://mint.com:8080/realms/nutshell/.well-known/openid-configuration",
"client_id": "cashu-client",
"protected_endpoints": [
{
"method": "POST",
Expand All @@ -40,7 +41,9 @@ The mint lists each protected endpoint that requires a clear authentication toke
}
```

`openid_discovery` is the OpenID Connect Discovery endpoint which has all the information necessary for a client to authenticate with the service. `protected_endpoints` is an array of objects that specify each endpoint that requires a CAT in the request headers. `method` is the HTTP method and `path` the path for the endpoint that is protected.
`openid_discovery` is the OpenID Connect Discovery endpoint which has all the information necessary for a client to authenticate with the service. `client_id` is the OpenID Connect Client ID that the wallet needs to use to authenticate.

`protected_endpoints` is an array of objects that specify each endpoint that requires a CAT in the request headers. `method` is the HTTP method and `path` the path for the endpoint that is protected.

The `path` can either be a string (exact match), such as `"/v1/auth/blind/mint"` or a regex pattern such as `"^/v1/mint/quote/bolt11/.*"`.

Expand Down

0 comments on commit 2e99618

Please sign in to comment.