Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Great clean up #51

Merged
merged 56 commits into from
Dec 29, 2023
Merged

Great clean up #51

merged 56 commits into from
Dec 29, 2023

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Nov 25, 2023

Update for cashubtc/nuts#55

Copy link

gitguardian bot commented Nov 25, 2023

⚠️ GitGuardian has uncovered 13 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
7000587 Generic High Entropy Secret ff0fead crates/cashu/src/nuts/nut00.rs View secret
7000587 Generic High Entropy Secret 93c2d47 crates/cashu/src/nuts/nut00.rs View secret
7000588 Generic High Entropy Secret ff0fead crates/cashu/src/nuts/nut00.rs View secret
7000588 Generic High Entropy Secret 93c2d47 crates/cashu/src/nuts/nut00.rs View secret
7000587 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
7000587 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
7000588 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
7000588 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
7972594 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
9126945 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
9126946 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
9126947 Generic High Entropy Secret ea25b35 crates/cashu/src/nuts/nut00.rs View secret
9126947 Generic High Entropy Secret 995a09f crates/cashu/src/nuts/nut00.rs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@thesimplekid thesimplekid marked this pull request as ready for review December 11, 2023 23:10
@thesimplekid thesimplekid marked this pull request as draft December 11, 2023 23:10
@thesimplekid thesimplekid merged commit 0fe7ccc into main Dec 29, 2023
16 checks passed
@thesimplekid thesimplekid deleted the great_clean_up branch March 31, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant