Add support for pure integration tests #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok300
force-pushed
the
ok300-simplify-integration-tests
branch
from
ba26c41 to
f506e6d
Compare
ok300
changed the title
ok300
force-pushed
the
ok300-simplify-integration-tests
branch
from
7a6bca5 to
479bc12
Compare
thesimplekid
approved these changes
Dec 2, 2024
ok300
force-pushed
the
ok300-simplify-integration-tests
branch
from
479bc12 to
6f0b2de
Compare
|
I rebased to include the recent I also had to add an explicit conversion between the |
ok300
force-pushed
the
ok300-simplify-integration-tests
branch
from
6f0b2de to
03adfff
Compare
vnprc
pushed a commit
to vnprc/cdk
that referenced
this pull request
Dec 18, 2024
* Embed mint_url as a field of HttpClient * Create pure integration tests * DirectMintConnection: convert between String and Uuid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR embeds the
mint_urlin theHttpClientitself, since every of its methods was anyway always with the wallet'smint_urlas arg.This has a few other benefits:
HttpClient("if URL A fails, try URL B")Notes to the reviewers
Suggested CHANGELOG Updates
CHANGED
Add support for pure integration tests
Checklist
just final-checkbefore committing