Keyset ID: fix deserialization edge-case, add unit tests #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesimplekid
approved these changes
Oct 24, 2024
ok300
force-pushed
the
ok300-fix-keyset-id-deserialization
branch
3 times, most recently
from
ed76e34 to
2cab443
Compare
ok300
force-pushed
the
ok300-fix-keyset-id-deserialization
branch
from
2cab443 to
2a09266
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge-case where the keyset ID could be deserialized from a string starting with a non
00byte into a valid keyset ID with the version byte00.The PR also
serdeannotations